Skip to content

master: Add partitioned communication APIs to TKR mpi module #9585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2021
Merged

master: Add partitioned communication APIs to TKR mpi module #9585

merged 1 commit into from
Oct 25, 2021

Conversation

tkordenbrock
Copy link
Member

@tkordenbrock tkordenbrock commented Oct 22, 2021 •
edited
Loading

See #9544

@tkordenbrock tkordenbrock added this to the v5.0.0 milestone Oct 22, 2021
@tkordenbrock tkordenbrock self-assigned this Oct 22, 2021
@tkordenbrock tkordenbrock marked this pull request as ready for review October 22, 2021 22:21
@tkordenbrock
Copy link
Member Author

@jsquyres I'm not sure how to test this one other than "it compiles".

@tkordenbrock tkordenbrock force-pushed the tkordenbrock/master/add-part-comm-to-tkr branch from 1c430f3 to f9f9a3e Compare October 22, 2021 22:38
@tkordenbrock tkordenbrock changed the title Add partitioned communication APIs to TKR mpi module master: Add partitioned communication APIs to TKR mpi module Oct 22, 2021
mdosanjh
mdosanjh reviewed Oct 22, 2021
View reviewed changes
Copy link
Contributor

@mdosanjh mdosanjh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to define PMPI_ macros that we need in pmpi-f90-interfaces.h, though I could be wrong.

@tkordenbrock tkordenbrock force-pushed the tkordenbrock/master/add-part-comm-to-tkr branch from f9f9a3e to 1b8b2d0 Compare October 23, 2021 12:18
@tkordenbrock
Copy link
Member Author

I think we need to define PMPI_ macros that we need in pmpi-f90-interfaces.h, though I could be wrong.

Ah yes. I missed that. Update pushed.

@tkordenbrock tkordenbrock force-pushed the tkordenbrock/master/add-part-comm-to-tkr branch from 1b8b2d0 to 2834ecc Compare October 24, 2021 20:17
mdosanjh
mdosanjh approved these changes Oct 24, 2021
View reviewed changes
Copy link
Contributor

@mdosanjh mdosanjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes appear to fix the TKR problem.

@tkordenbrock tkordenbrock merged commit 9f3134c into open-mpi:master Oct 25, 2021
@awlauria awlauria mentioned this pull request Nov 3, 2021
Closed
@tkordenbrock tkordenbrock deleted the tkordenbrock/master/add-part-comm-to-tkr branch November 5, 2021 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdosanjh mdosanjh mdosanjh approved these changes

@jsquyres jsquyres Awaiting requested review from jsquyres

Assignees

@tkordenbrock tkordenbrock

Labels
Target: main
Projects
None yet
Milestone
v5.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tkordenbrock @mdosanjh