btl: introduce flag MCA_BTL_FLAGS_RDMA_REMOTE_COMPLETION #9694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch introduced a new flag MCA_BTL_FLAGS_RDMA_REMOTE_COMPLETION, which is used to indicate whether a btl's RDMA/atomic operations support remote completion. btl/self, btl/ofi and btl/ugni support remote completion, thus this patch added the flags to them. Active message RDMA/atomic supports remote completion under certain condition, this patch implemented that logic. Signed-off-by: Wei Zhang <[email protected]>
This was referenced Nov 23, 2021
bwbarrett
approved these changes
Nov 23, 2021
| @@ -1138,5 +1138,28 @@ int mca_btl_base_am_rdma_init(mca_btl_base_module_t *btl) | |||
| OBJ_CONSTRUCT(&default_module, mca_btl_base_am_rdma_module_t); | |||
| } | |||
|
|
|||
| /* This section check whether we can claim support of remote completion. | |||
There was a problem hiding this comment.
I don't think you need this first line of the comment. But I do love the detailed comment!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch introduced a new flag MCA_BTL_FLAGS_RDMA_REMOTE_COMPLETION,
which is used to indicate whether a btl's RDMA/atomic operations support
remote completion.
btl/self, btl/ofi and btl/ugni support remote completion, thus this patch
added the flags to them.
Active message RDMA/atomic supports remote completion under certain
condition, this patch implemented that logic.
Signed-off-by: Wei Zhang [email protected]