ompi/attr: update attribute system to prepare for sessions #9848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates how the attribute system is initialized. Instead of being set up in MPI_Init it is initialized by the subsystems (communicator, windows, datatypes) that use it. To keep the delta from the sessions PR minimal the ompi_mpi_instance_retain() and ompi_mpi_instance_release() functions are stubbed out as no-ops. This will be removed once the instance system is added. Signed-off-by: Nathan Hjelm <[email protected]>
|
Pulled out of #9097 for separate review. |
hppritcha
approved these changes
Jan 10, 2022
|
@hjelmn out of curiosity is this for some other work besides sessions? |
|
@hppritcha No. This is sesssions only. I was reviewing the PR and figured we can probably pull some pieces out to make it easier to review. Things like this attribute change are needed for sessions as implemented but work fine without the instances code. |
|
@bosilca Any comments on this change? |
bosilca
approved these changes
Jan 12, 2022
|
Ok, will try to rebase the sessions PR now and we can continue to iterate. |
|
@hjelmn i already rebased |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates how the attribute system is initialized. Instead of
being set up in MPI_Init it is initialized by the subsystems (communicator,
windows, datatypes) that use it. To keep the delta from the sessions PR
minimal the ompi_mpi_instance_retain() and ompi_mpi_instance_release()
functions are stubbed out as no-ops. This will be removed once the instance
system is added.
Signed-off-by: Nathan Hjelm [email protected]