Allow explicit use of the Active Message RDMA interface #9904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwbarrett
force-pushed
the
bugfix/rdma-osc-am-refactor
branch
from
3b6e81a to
517424b
Compare
|
#9903 did, in fact, create some small conflicts that are resolved in the latest update. |
|
bot:aws:retest (no idea; one of the test sets got killed by Jenkins for ?reasons?). |
Remove the type-specific implementation of min in the btl active message code and use opal_min instead. While this loses type safety in the general case, most compilers used in development support C generics, so we'll still get type safety checks. Signed-off-by: Brian Barrett <[email protected]>
gpaulsen
reviewed
Jan 25, 2022
Rename internal functions in the btl am-rdma code to be consistently prefixed by am_rdma_. Previously, there was a mixture of prefixes, all of which were unnecessarily long for private functions. There is no external-visible change in this commit. Signed-off-by: Brian Barrett <[email protected]>
Disable the underlying flush() call when using the am-rdma interfce. The current code does not properly handle flushing between the am-rdma and underlying code properly, so it is quite easy to end up with flush not behaving the way users expect. Since there are currently no callers that rely on a btl having both flush and am-rdma interfaces, explicitly disable the case for now. Signed-off-by: Brian Barrett <[email protected]>
Add per-btl storage for the am-rdma interface, allowing the interface to make one-time decisions about whether or not to use the underlying put/get interfaces. This is a necessary step in allowing users of the am-rdma interface to require different semantics (completion, registration, etc.) than what is natively provided by the BTL. Signed-off-by: Brian Barrett <[email protected]>
Add a mode for the am-rdma interface where the existing BTL is not updated, but the wrapper functions are exported directly to the caller. This interface allows for specifying required flags (although REMOTE_COMPLETION is the only one supported today) and disabling memory registration requirements for the returned interface. Signed-off-by: Brian Barrett <[email protected]>
The front end functions for am-rdma atomic operations only allow a 4 or 8 byte atomic. Add an assert on the progress function that the received size is less than a uint8_t can hold before assignment from a size_t. Signed-off-by: Brian Barrett <[email protected]>
bwbarrett
force-pushed
the
bugfix/rdma-osc-am-refactor
branch
from
517424b to
341f164
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AM RDMA interface previously only could be used by updating a btl to fill in missing interfaces. However, it has the capability of providing stronger semantics than the underlying BTL (like providing remote completion even if the underlying BTL doesn't). Provide an external interface to the AM RDMA code that will be used by the RDMA OSC code when the underlying BTLs don't provide remote completion or the required put/get/atomic interfaces.