Skip to content

Conversation

fraillt
Copy link
Contributor

@fraillt fraillt commented Nov 7, 2024

Fixes #2146

Changes

Refactored ExpoHistogram to use ValueMap for consistency and efficiency.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@fraillt fraillt requested a review from a team as a code owner November 7, 2024 06:57
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 95.83333% with 5 lines in your changes missing coverage. Please review.

Project coverage is 79.5%. Comparing base (cd54f24) to head (82e2859).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...-sdk/src/metrics/internal/exponential_histogram.rs 95.8% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #2282     +/-   ##
=======================================
- Coverage   79.5%   79.5%   -0.1%     
=======================================
  Files        123     123             
  Lines      21293   21282     -11     
=======================================
- Hits       16938   16927     -11     
  Misses      4355    4355             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@fraillt fraillt force-pushed the value-map-on-expo-histogram branch from e1e82f9 to b357e51 Compare November 20, 2024 18:32
@cijothomas cijothomas merged commit 3b652ac into open-telemetry:main Nov 20, 2024
24 of 25 checks passed
@fraillt fraillt deleted the value-map-on-expo-histogram branch November 21, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Apply ValueMap for ExpoHistogram metric

2 participants