Skip to content

chore: modify BatchLogProcessor method to accept max_export_size: usize parameter instead of config: &BatchConfig #3119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 5, 2025

Conversation

cijothomas
Copy link
Member

No description provided.

@cijothomas cijothomas requested a review from a team as a code owner August 5, 2025 05:15
Copy link

codecov bot commented Aug 5, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.5%. Comparing base (1106b0f) to head (0a37b9f).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
opentelemetry-sdk/src/logs/batch_log_processor.rs 66.6% 2 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #3119   +/-   ##
=====================================
  Coverage   80.5%   80.5%           
=====================================
  Files        126     126           
  Lines      22218   22218           
=====================================
  Hits       17889   17889           
  Misses      4329    4329           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cijothomas cijothomas requested a review from Copilot August 5, 2025 05:18
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the BatchLogProcessor by simplifying function parameters to pass only the required max_export_batch_size value instead of the entire BatchConfig object.

Key Changes

  • Modified function signature to accept max_export_size: usize parameter instead of config: &BatchConfig
  • Updated all function calls to pass the specific max_export_batch_size value instead of the config object
Comments suppressed due to low confidence (1)

opentelemetry-sdk/src/logs/batch_log_processor.rs:363

  • The parameter name max_export_size is inconsistent with the variable name max_export_batch_size used in the function calls. Consider renaming to max_export_batch_size for consistency.
                    max_export_size: usize,

@lalitb lalitb changed the title chore: nit rename to batchlogprocessor chore: modify BatchLogProcessor method to accept max_export_size: usize parameter instead of config: &BatchConfig Aug 5, 2025
@cijothomas cijothomas merged commit c7e47de into open-telemetry:main Aug 5, 2025
26 of 28 checks passed
@cijothomas cijothomas deleted the cijothomas/blp-nits branch August 5, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants