Skip to content

Fix reqwest feature dependency for zipkin #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 30, 2020
Merged

Fix reqwest feature dependency for zipkin #322

merged 2 commits into from
Oct 30, 2020

Conversation

jtescher
Copy link
Member

@jtescher jtescher commented Oct 30, 2020 •
edited
Loading

Currently opentelemetry-zipkin will not compile with the non-blocking reqwest configuration as reqwest is not specified as a dependency.

Fixes #321

@jtescher jtescher requested a review from a team October 30, 2020 18:20
TommyCpp
TommyCpp approved these changes Oct 30, 2020
View reviewed changes
Copy link
Contributor

@TommyCpp TommyCpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May need to fix it in datadog exporter too.

opentelemetry-rust/opentelemetry-contrib/Cargo.toml

Line 25 in 468adf9

reqwest-client = ["opentelemetry/reqwest"]

@jtescher jtescher merged commit 396dd88 into master Oct 30, 2020
@jtescher jtescher deleted the zipkin-reqwest-fix branch October 30, 2020 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TommyCpp TommyCpp TommyCpp approved these changes

+1 more reviewer

@frigus02 frigus02 frigus02 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Actix Zipkin exemples
3 participants
@jtescher @frigus02 @TommyCpp