-
Notifications
You must be signed in to change notification settings - Fork 583
Move opentelemetry crate into a directory to flatten the workspace #324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5141dea
to
e3cf274
Compare
Should probably move the changelog in as well as each crate has their own |
682e369
to
4efab0b
Compare
So the new meta job is failing without a clear error message. It looks like it can no longer find |
@djc the |
This makes working with cargo easier, because many commands (like cargo check, cargo test) will apply to all crates by default, rather than only selecting the crate in the top-level directory.
Codecov Report
@@ Coverage Diff @@
## master #324 +/- ##
===========================================
+ Coverage 41.11% 53.42% +12.30%
===========================================
Files 73 71 -2
Lines 8615 5758 -2857
===========================================
- Hits 3542 3076 -466
+ Misses 5073 2682 -2391
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @djc still working on things? or is this ready to be merged.
Nope, I'm happy! |
This makes working with cargo easier, because many commands (like cargo
check, cargo test) will apply to all crates by default, rather than
only selecting the crate in the top-level directory.