Skip to content

Conversation

djc
Copy link
Contributor

@djc djc commented Oct 31, 2020

This makes working with cargo easier, because many commands (like cargo
check, cargo test) will apply to all crates by default, rather than
only selecting the crate in the top-level directory.

@djc djc requested a review from a team October 31, 2020 12:18
@djc djc force-pushed the flat-workspace branch 5 times, most recently from 5141dea to e3cf274 Compare October 31, 2020 14:44
@jtescher
Copy link
Member

Should probably move the changelog in as well as each crate has their own

@djc djc force-pushed the flat-workspace branch 4 times, most recently from 682e369 to 4efab0b Compare November 1, 2020 13:09
@djc
Copy link
Contributor Author

djc commented Nov 1, 2020

So the new meta job is failing without a clear error message. It looks like it can no longer find protoc, maybe? @jtescher, any ideas?

@jtescher
Copy link
Member

jtescher commented Nov 1, 2020

@djc the opentelemetry crate was the default before, think adding -p opentelemetry should fix the tests

This makes working with cargo easier, because many commands (like cargo
check, cargo test) will apply to all crates by default, rather than
only selecting the crate in the top-level directory.
@codecov
Copy link

codecov bot commented Nov 1, 2020

Codecov Report

Merging #324 into master will increase coverage by 12.30%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #324       +/-   ##
===========================================
+ Coverage   41.11%   53.42%   +12.30%     
===========================================
  Files          73       71        -2     
  Lines        8615     5758     -2857     
===========================================
- Hits         3542     3076      -466     
+ Misses       5073     2682     -2391     
Impacted Files Coverage Δ
opentelemetry/src/api/baggage.rs 80.00% <ø> (ø)
opentelemetry/src/api/context.rs 71.42% <ø> (ø)
opentelemetry/src/api/core.rs 58.24% <ø> (ø)
opentelemetry/src/api/labels/encoder.rs 0.00% <ø> (ø)
opentelemetry/src/api/labels/mod.rs 0.00% <ø> (ø)
opentelemetry/src/api/metrics/async_instrument.rs 0.00% <ø> (ø)
opentelemetry/src/api/metrics/config.rs 31.57% <ø> (ø)
opentelemetry/src/api/metrics/descriptor.rs 30.23% <ø> (ø)
opentelemetry/src/api/metrics/kind.rs 5.26% <ø> (ø)
opentelemetry/src/api/metrics/meter.rs 0.00% <ø> (ø)
... and 64 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2574dd5...8b759a6. Read the comment docs.

Copy link
Member

@jtescher jtescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @djc still working on things? or is this ready to be merged.

@djc
Copy link
Contributor Author

djc commented Nov 1, 2020

Nope, I'm happy!

@jtescher jtescher merged commit f9e91e7 into open-telemetry:master Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants