Skip to content

Conversation

djc
Copy link
Contributor

@djc djc commented Nov 11, 2020

No description provided.

@djc djc requested a review from a team November 11, 2020 12:46
@codecov
Copy link

codecov bot commented Nov 11, 2020

Codecov Report

Merging #360 (edf568c) into master (68f041a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #360   +/-   ##
=======================================
  Coverage   54.56%   54.56%           
=======================================
  Files          70       70           
  Lines        5914     5914           
=======================================
  Hits         3227     3227           
  Misses       2687     2687           
Impacted Files Coverage Δ
opentelemetry/src/lib.rs 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68f041a...edf568c. Read the comment docs.

@TommyCpp
Copy link
Contributor

I think we thought about it back then but decided not to add it as it didn't seem to be in active development. But if that's not the case, 👍 for adding it.

@djc
Copy link
Contributor Author

djc commented Nov 11, 2020

I've brought it up to date. If it goes silent again I'll fork it.

Copy link
Member

@jtescher jtescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add this to the README as well? (currently both this crate and repo root readmes, could consider making one a symlink)

@djc djc force-pushed the otel-stackdriver branch from fa5cbfb to 1eaafdb Compare November 11, 2020 17:46
@djc
Copy link
Contributor Author

djc commented Nov 11, 2020

Done.

@jtescher jtescher merged commit 310df35 into open-telemetry:master Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants