#581: Add OverrideStrategy enum for the fakeable trait to support merge/replace
#646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng responses, updating `Fakeable::fake()` and its attribute builder accordingly.
droath
changed the title
OverrideStrategy enum and enable merge/replace OverrideStrategy enum for the fakeable trait to support merge/replace
iBotPeaches
reviewed
Aug 14, 2025
|
Okay—I was able to get the unit tests and linting all passing locally. I've added a test case that will ensure it works as expected when using either the replace or merge strategy. |
iBotPeaches
approved these changes
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Description:
I ran into an issue that relates to the bug described at https://github.com/openai‑php/client/issues/581. This PR fixes that issue, and all PHPUnit tests have passed with these changes.
References:
fixes: #581