Skip to content

Improved the README (again) #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Mar 30, 2024
Merged

Improved the README (again) #337

merged 12 commits into from
Mar 30, 2024

Conversation

RaptaG
Copy link
Contributor

@RaptaG RaptaG commented Oct 27, 2023

Signed-off-by: RaptaG [email protected]

@MagicLike MagicLike self-requested a review October 27, 2023 13:11
MagicLike
MagicLike requested changes Oct 28, 2023
View reviewed changes
Copy link
Member

@MagicLike MagicLike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looking good!

MagicLike
MagicLike approved these changes Oct 28, 2023
View reviewed changes
Copy link
Member

@MagicLike MagicLike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MagicLike MagicLike requested a review from tsterbak October 28, 2023 17:19
@tsterbak tsterbak added the documentation Improvements or additions to documentation label Oct 28, 2023
@MagicLike MagicLike added the hacktoberfest-accepted PR accepted for Hacktoberfest label Oct 28, 2023
tsterbak
tsterbak approved these changes Oct 29, 2023
View reviewed changes
Copy link
Member

@tsterbak tsterbak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

tsterbak
tsterbak previously requested changes Oct 29, 2023
View reviewed changes
@RaptaG @tsterbak
Small grammer fix
c5a01b1 
Co-authored-by: Tobias Sterbak <[email protected]>
@MagicLike MagicLike changed the base branch from main to dev October 31, 2023 16:21
@MagicLike MagicLike added this to the Release Beta-Version 0.5.1 milestone Oct 31, 2023
@MagicLike
Copy link
Member

Hey @RaptaG, would it be possible to make the requested changes, so that it can get merged into the current dev and pulled over to main with the upcoming release?

@MagicLike MagicLike mentioned this pull request Oct 31, 2023
Merged
@RaptaG
Copy link
Contributor Author

RaptaG commented Nov 1, 2023

Hey @RaptaG, would it be possible to make the requested changes, so that it can get merged into the current dev and pulled over to main with the upcoming release?

Alright, I'll apply everything now!

@RaptaG
Copy link
Contributor Author

RaptaG commented Nov 1, 2023 •
edited
Loading

@tsterbak could you not name the release files with their release number so that I may include them like this:

https://github.com/openandroidinstaller-dev/openandroidinstaller/releases/download/latest/openandroidinstaller-ubuntu-latest.zip

https://github.com/openandroidinstaller-dev/openandroidinstaller/releases/download/latest/openandroidinstaller-macos-latest.zip

https://github.com/openandroidinstaller-dev/openandroidinstaller/releases/download/latest/openandroidinstaller-windows-latest.zip

(aka name the files openandroidinstaller-windows.zip, openandroidinstaller-macos.zip, openandroidinstaller-ubuntu-latest & openandroidinstaller-ubuntu-20.04.zip)

RaptaG added 2 commits November 1, 2023 16:13
@RaptaG
Apply requested suggestions
a58b29a 
Signed-off-by: RaptaG <[email protected]>
@RaptaG
Quick fix
6b1c539 
Signed-off-by: RaptaG <[email protected]>
@RaptaG
Copy link
Contributor Author

RaptaG commented Nov 1, 2023

If you have any other suggestions lmk!
Also, I'd love some help with resolving the merge conflicts..

@tsterbak
Copy link
Member

tsterbak commented Nov 1, 2023

@tsterbak could you not name the release files with their release number so that I may include them like this:

No, I want to release number in it to make it clear which release it is and to be able to link to different files easily. Just link to the release page, that should be fine.

@tsterbak
Copy link
Member

tsterbak commented Nov 1, 2023

If you have any other suggestions lmk!

I will have a look and let you know :) Thank you!

Also, I'd love some help with resolving the merge conflicts..

I can try to resolve them :)

@MagicLike MagicLike requested a review from tsterbak November 1, 2023 16:02
@MagicLike
Copy link
Member

Also, I'd love some help with resolving the merge conflicts..

I can try to resolve them :)

Already done! :D

MagicLike
MagicLike requested changes Nov 1, 2023
View reviewed changes
Copy link
Member

@MagicLike MagicLike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally a really nice upgrade for the README, but please consider implementing my requested changes!

@MagicLike MagicLike removed this from the Release Beta-Version 0.5.1 milestone Nov 1, 2023
@MagicLike MagicLike changed the base branch from dev to main November 1, 2023 16:30
@ghost
Copy link

ghost commented Nov 1, 2023

Little improvement, I think it can be done here : can Xiaomi devices be sorted? (even it's somewhat hard ^^)
Group “Redmi Note” together, “Redmi ...A”, “Poco”, “Mi” too... And maybe add "Poco” to the brand header, like “Xiaomi / Poco”?

@RaptaG
Copy link
Contributor Author

RaptaG commented Nov 2, 2023

I'll try to apply everything soon @MagicLike

@RaptaG
Copy link
Contributor Author

RaptaG commented Nov 4, 2023

I'll add them later today

@RaptaG
Copy link
Contributor Author

RaptaG commented Nov 4, 2023

Little improvement, I think it can be done here : can Xiaomi devices be sorted? (even it's somewhat hard ^^) Group “Redmi Note” together, “Redmi ...A”, “Poco”, “Mi” too... And maybe add "Poco” to the brand header, like “Xiaomi / Poco”?

I didn't categorize them though I added Poco on the header

@RaptaG
Copy link
Contributor Author

RaptaG commented Nov 4, 2023

Everything is ready now @MagicLike

@MagicLike
Copy link
Member

Little improvement, I think it can be done here : can Xiaomi devices be sorted? (even it's somewhat hard ^^) Group “Redmi Note” together, “Redmi ...A”, “Poco”, “Mi” too... And maybe add "Poco” to the brand header, like “Xiaomi / Poco”?

I didn't categorize them though I added Poco on the header

The tables need a rework at some point anyway, so it shouldn't be an issue rn 👍

MagicLike
MagicLike approved these changes Nov 4, 2023
View reviewed changes
Copy link
Member

@MagicLike MagicLike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT! - I think this can get merged, other changes can still be done in the future 👍

@MagicLike
Copy link
Member

@tsterbak Can you take a look if this on can finally be merged?

@tsterbak tsterbak changed the base branch from main to dev November 24, 2023 13:34
@tsterbak tsterbak changed the base branch from dev to main November 24, 2023 13:34
@tsterbak
Copy link
Member

I requested some changes, otherwise it looks good :)

@tsterbak
Copy link
Member

Any updates on this? I would love to get this merged 😊

@MagicLike
Copy link
Member

Any updates on this? I would love to get this merged 😊

afaik it is finished and just waiting for the merge...

tsterbak
tsterbak requested changes Jan 14, 2024
View reviewed changes
@MagicLike
Copy link
Member

Any updates on this one @RaptaG?

@RaptaG
Copy link
Contributor Author

RaptaG commented Mar 27, 2024

Any updates on this one @RaptaG?

Oh, right, I forgot about this one
Ι will finish it tomorrow, at about 16:30 GMT+2

@RaptaG
Copy link
Contributor Author

RaptaG commented Mar 28, 2024

@tsterbak @MagicLike how does it look now?

@RaptaG
Copy link
Contributor Author

RaptaG commented Mar 28, 2024

Also, could I get some help resolving the conflicts?

@tsterbak tsterbak merged commit 562acd3 into openandroidinstaller-dev:main Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsterbak tsterbak tsterbak approved these changes

@MagicLike MagicLike MagicLike approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation hacktoberfest-accepted PR accepted for Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RaptaG @MagicLike @tsterbak