Faster highlight creation #523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't understand why this would be necessary -- the element's just been created, no style is (presumably) changing its display to anything other than the default... -- and when highlighting all text in a 5000×3 table, $.show() accounts for 10s out of the 14s it takes to draw the highlights. $.show() being absurdly slow is a known problem: jquery/jquery.com#88
This funtion accounted for ~1 second of the remaining time in my 5000×3 table test case. With this change it's more like 200ms, which is still not ideal but a lot better. $.wrapAll seems relatively expensive. I suppose it has to do lots of extra work that's not necessary when we know we have exactly one element to wrap at a time.
|
Just about to hop on a plane, but this looks fine to me. I can't see any reason to call |
|
👍 from me. |
|
Use of the global |
mwidner
added a commit
to PoeticMediaLab/annotator
that referenced
this pull request
Nov 19, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not the big reorganisation discussed on #521 but this fixes a different big bottleneck for me.
There must be some reason you are calling
.show()on all thespans – perhaps defending against the page having some CSS which applies to allspans and hides them or something like that? I'm not sure how big a problem this is in practice, or how to work around it without calling.show()– set a defensivedisplay: inherit;onspan.annotator-hland hope that there's no more specific style in effect?