Remove util.getGlobal() #527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjt
added a commit
to wjt/xpath-range
that referenced
this pull request
May 3, 2015
Per openannotation/annotator#527 . We actually don't need to use global at all -- we can get the document from the element we're about to walk.
|
@tilgovi still planning to merge this? Looks like the build failures are Sauce Labs related...not code. So that's good. 😃 |
Let browserify do the work of giving us the window object and avoid using anonymous code evaluation.
tilgovi
force-pushed
the
remove-get-global
branch
from
00d8612 to
0016813
Compare
|
Bump. Should resolve #542 as well, I hope. |
|
Oops. |
|
I didn't mean to merge this. But I did. Ah, well. I think it should be fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Browserify does the right thing with
global.