Skip to content

Allow tweaking configuration of black and isort via custom templates #750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
machinehead opened this issue Apr 21, 2023 · 1 comment
Closed
Labels
✨ enhancement New feature or improvement

Comments

@machinehead
Copy link
Contributor

machinehead commented Apr 21, 2023

Is your feature request related to a problem? Please describe.
I'm using a monorepo with multiple projects, where some of the projects are generated by openapi-python-client.
I'd like to have a single configuration of black and isort at the top level of the monorepo, but having them included in pyproject.toml of generated projects breaks that.

Describe the solution you'd like
I'd like to be able to use custom templates to alter the configuration of black and isort in generated projects, while not having to copy the rest of poetry's configuration into my custom templates.

Describe alternatives you've considered
I've considered using generate once, then manually tweaking pyproject.toml and doing update afterwards. However, I don't like this approach, since it leads to having non-reproducible manual edits.

Additional context
I think this can be achieved by a very simple one-line change that also reduces some code duplication; I'll be sending a PR for this shortly.

@machinehead machinehead added the ✨ enhancement New feature or improvement label Apr 21, 2023
machinehead added a commit to machinehead/openapi-python-client that referenced this issue Apr 21, 2023
@machinehead
Copy link
Contributor Author

PR: #751

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ enhancement New feature or improvement
Projects
None yet
Development

No branches or pull requests

1 participant