Skip to content

Attribute named client end up in 2 arguments named client #758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
truenicoco opened this issue May 6, 2023 · 1 comment · Fixed by #765
Closed

Attribute named client end up in 2 arguments named client #758

truenicoco opened this issue May 6, 2023 · 1 comment · Fixed by #765
Labels
🐞bug Something isn't working

Comments

@truenicoco
Copy link

Example generated output from mattermost openapi shema:

def sync_detailed(
    team_id: str,
    *,
    client: Client,
    client_version: str,
    locale: Union[Unset, None, str] = UNSET,
    client: str,  # nope, client was already used before
) -> Response[Union[Any, List["Notice"]]]:
@truenicoco truenicoco added the 🐞bug Something isn't working label May 6, 2023
@dbanty
Copy link
Collaborator

dbanty commented May 6, 2023

We probably need to special-case client and always append location (like we do for duplicate parameters)

dbanty added a commit that referenced this issue May 27, 2023

Verified

This commit was signed with the committer’s verified signature.
davidtwco David Wood
…anks @truenicoco & @juanber84!

* fix: Allow parameters named "client" and "url"

* chore: Cleanup unused import

* chore: Hold mypy's hand

---------

Co-authored-by: Dylan Anthony <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants