Skip to content

The version of the OpenAPI doc is now used as the generated library's… #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

emann
Copy link
Collaborator

@emann emann commented Aug 5, 2020

Closes #134

@codecov
Copy link

codecov bot commented Aug 6, 2020

Codecov Report

Merging #135 into main will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #135   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           40        40           
  Lines         1158      1159    +1     
=========================================
+ Hits          1158      1159    +1     
Impacted Files Coverage Δ
openapi_python_client/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2206b0...0480177. Read the comment docs.

@dbanty
Copy link
Collaborator

dbanty commented Aug 6, 2020

@emannguitar will you add a note to the CHANGELOG about this? It will be in 0.5.2 (if that section doesn't already exist)

@emann emann force-pushed the feature/version_from_openapi_doc branch from c16e1dd to a857ff0 Compare August 6, 2020 14:33
@dbanty dbanty merged commit 9587f59 into openapi-generators:main Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use the "version" field in the OpenAPI doc as the version of the generated library
2 participants