Add response content to UnexpectedStatus exception #989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbanty
changed the title
dbanty
added a commit
that referenced
this pull request
Mar 6, 2024
This PR was created by Knope. Merging it will create a new release ### Breaking Changes #### Update PDM metadata syntax Metadata generated for PDM will now use the new `distribution = true` syntax instead of `package-type = "library"`. New packages generated with `--meta pdm` will require PDM `2.12.0` or later to build. ### Features #### Add response content to `UnexpectedStatus` exception The error message for `UnexpectedStatus` exceptions will now include the UTF-8 decoded (ignoring errors) body of the response. PR #989 implements #840. Thanks @harabat! ### Fixes #### Allow hyphens in path parameters Before now, path parameters which were invalid Python identifiers were not allowed, and would fail generation with an "Incorrect path templating" error. In particular, this meant that path parameters with hyphens were not allowed. This has now been fixed! PR #986 fixed issue #976. Thanks @harabat! > [!WARNING] > This change may break custom templates, see [this diff](https://github.com/openapi-generators/openapi-python-client/pull/986/files#diff-0de8437b26075d8fe8454cf47d8d95d4835c7f827fa87328e03f690412be803e) > if you have trouble upgrading. Co-authored-by: GitHub <[email protected]>
|
Thanks x2 @dbanty! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #839 and #840
This is a simple change that adds the response content to the
UnexpectedStatusexception, which is currently the most upvoted feature in Discussions.