Skip to content
This repository was archived by the owner on Mar 16, 2025. It is now read-only.

generic parameter #31

Merged
merged 3 commits into from
Nov 6, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/main/antlr/To.g4
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ typeArgumentList
typeArgument
: type
| '?'
| .*?
;


Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ open class MappedDataType(
}

override fun getImports(): Set<String> {
return setOf("${getPackageName()}.$type") + genericTypes
return setOf("${getPackageName()}.$type") + genericTypes.filter { it != "?" }
}

private fun getGenericTypeNames(): List<String> {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,12 @@ class ToExtractor: ToBaseListener() {
ctx.typeArguments ()
?.typeArgumentList ()
?.typeArgument ()
?.filter { it.type() != null }
?.forEach {
typeArguments.add(it.type ().text)
if (it.text == "?") {
typeArguments.add("?")
} else if (it.type() != null) {
typeArguments.add(it.type ().text)
}
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ class MappedDataTypeSpec extends Specification {
where:
generics | typeName
[] | 'Foo'
['?'] | 'Foo<?>'
['java.lang.String'] | 'Foo<String>'
['java.lang.String', 'java.lang.String'] | 'Foo<String, String>'
}
Expand All @@ -46,6 +47,7 @@ class MappedDataTypeSpec extends Specification {
where:
generics | imports
[] | ['model.Foo']
['?'] | ['model.Foo']
['java.lang.String'] | ['model.Foo', 'java.lang.String']
['java.lang.String', 'java.lang.String'] | ['model.Foo', 'java.lang.String']
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ class ToParserSpec extends Specification {
'io.openapiprocessor.Foo' | 'io.openapiprocessor.Foo' | []
' io . openapiprocessor . Foo ' | 'io.openapiprocessor.Foo' | []
'A<>' | 'A' | []
'A<?>' | 'A' | []
'A<?>' | 'A' | ['?']
'A<b.B, c.C>' | 'A' | ['b.B', 'c.C']
'A<B, C>' | 'A' | ['B', 'C']
}
Expand Down