This repository was archived by the owner on Mar 16, 2025. It is now read-only.
Apply NotNull bean-validation to allOf composition #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A type composed using allOf must validate against all listed types. When these types have required properties, these properties are thus also required in the composed type. To correctly annotate those properties with NotNull, set constraints on the AllOfObjectDataType based on its items.
|
I may fix this slightly different but your pull request is good starting point with the tests in place. :-) Thanks for the report & fix. :-) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using allOf and bean validation, the properties of the composed type do not get annotated with NotNull even though they are marked as required in the schema. While creating and checking a test-case, I came up with a potential fix.
The tests are copied and modified from 2 existing ones.