Schemas are parsed in spinal case instead of camel case when using path references

[rombru]

Hello,

When using path reference,

  '/users/{userId}':
    $ref: ./apis/user.v1.yaml#/paths/~1users~1{userId}

The schemas used by the referenced path are parsed in spinal-case,
public class user {

For schemas whose name is in several parts, like UserSearch, the parser writes a hyphen (user-search) and stops because the syntax of java doesn't support that.

Because it's a bit complicated to exlain I've attached the full example
openapi-bug.zip

[hauner]

Interesting, I didn't know you can navigate like this.

I will take a look at which level this is going wrong. Thanks for the example.

Reference:
https://stackoverflow.com/questions/58909124/how-to-use-ref-to-reference-a-path-from-another-openapi-file
https://stackoverflow.com/questions/44150758/swagger-2-0-multiple-path-objects-with-different-paths-but-same-request-and-res/44164413#44164413

[rombru]

I've tested different use cases of path references, while looking at your tests.

Here's another example that shows a problem with page composition, and one with global parameters:

• Instead of ResponseEntity <Page >, the parser write ResponseEntity >
• Parameters used for multiple paths are not read. An example is in the file user-userId.api.v1.yaml.

openapi-bug-pageable-and-params.zip

I will not use references between the paths for now, that's no big deal.
Hope the example helps you a bit more.

[hauner]

The examples help a lot, Thanks.

The issue is that the processor tries to get schema names (titles) of $refs by extracting them from the $ref path. That fails for a lot of $refs in your example.

Looking at it now, I don't understand why it works at all ;-)

[hauner]

Fixed it. Both examples produce proper code now. :-)

That was a nasty one, but my original code wasn't so bad at all. The swagger parser is doing something very similar internally. :-)

Release will follow in the next days.

[rombru]

Nice ! So quick !

I have no doubts about the quality of the code.
This is one of the reasons that pushes me to use it.

Thank you 😃

[hauner]

published 2021.3, fixing this one.