Skip to content

missing import for javax.validation.constraints.Pattern #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kugelstachelfisch opened this issue May 17, 2022 · 2 comments
Closed

missing import for javax.validation.constraints.Pattern #141

kugelstachelfisch opened this issue May 17, 2022 · 2 comments
Labels
bug Something isn't working
Milestone
2022.4

Comments

@kugelstachelfisch
Copy link

kugelstachelfisch commented May 17, 2022 •
edited
Loading

Hi there, thanks for the great job!
I've found a minor issue:

When array-elements of type string are described by a pattern and the array is mapped to java.util.List, the import for @Pattern-Annotation is missing.

I've tested with openapi-processor-spring V2022.3.

A minimal testcase is attached. Without the line import javax.validation.constraints.Pattern;, the test runs successfully, but the import is required to compile.

list-pattern-missing-import.zip
@hauner hauner added the bug Something isn't working label May 18, 2022
@hauner
Copy link
Member

hauner commented May 18, 2022 •
edited
Loading

yep, looks like a bug. Thanks for the test-case :-)

hauner added a commit to openapi-processor/openapi-processor-core that referenced this issue May 18, 2022
@hauner
openapi-processor/openapi-processor-spring#141, fix bean validation i…
d4ac8c3 
…mports
hauner added a commit to openapi-processor/openapi-processor-core that referenced this issue May 18, 2022
@hauner
openapi-processor/openapi-processor-spring#141, typo
22878d4
@hauner hauner modified the milestones: core: next, 2022.4 May 18, 2022
@hauner
Copy link
Member

hauner commented May 29, 2022

fix is available in openapi-processor-spring 2022.4

@hauner hauner closed this as completed May 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
2022.4
Development

No branches or pull requests
2 participants
@hauner @kugelstachelfisch