Skip to content

[email protected] missing 'dist' in package #2032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task
jgoz opened this issue Dec 2, 2024 · 10 comments · Fixed by #2037
Closed
1 task

[email protected] missing 'dist' in package #2032

jgoz opened this issue Dec 2, 2024 · 10 comments · Fixed by #2037
Assignees
Labels
bug Something isn't working openapi-fetch Relevant to the openapi-fetch library

Comments

@jgoz
Copy link

jgoz commented Dec 2, 2024

Description

I happened to install the latest version (0.13.2) and noticed that the package is missing the dist directory. 0.13.1 is fine.

Reproduction

npm i [email protected]
ls -al node_modules/openapi-fetch

Expected result

(in case it’s not obvious)

Checklist

@jgoz jgoz added bug Something isn't working openapi-fetch Relevant to the openapi-fetch library labels Dec 2, 2024
@bkis
Copy link

bkis commented Dec 3, 2024

My build failing after installing 0.13.2 is probably related to this...

vite v6.0.1 building for production...
transforming...
✓ 434 modules transformed.
x Build failed in 2.50s
error during build:
[commonjs--resolver] Failed to resolve entry for package "openapi-fetch". The package may have incorrect main/module/exports specified in its package.json.
...

@xobotyi
Copy link

xobotyi commented Dec 3, 2024

Same here, 0.13.2 lacks dist folder, 0.13.1 is fine

@eduhdev12
Copy link

Same issue, builds are failing 😕

@stefcameron
Copy link

I'm also seeing the same missing ./dist in the recently-published [email protected] while 0.2.6 has the ./dist directory...

@aguynamedben
Copy link

Same here, it's my first time using openapi-fetch and my editor couldn't find the import. yarn chose to install 0.13.2, which is published to npm but not documented on the GitHub releases page. Downgrading to 0.13.1 worked.

@gzm0
Copy link
Contributor

gzm0 commented Dec 4, 2024

@drwpow could this be because of the turborepo upgrade?

@gzm0
Copy link
Contributor

gzm0 commented Dec 4, 2024

First of all, apologies for the bad publish. We are still analyzing what has happened and what the impact is (notably if there are other bad packages).

Investigation info:
Bad release commit: 7dfcf25
Release workflow: https://github.com/openapi-ts/openapi-typescript/actions/runs/12129439515/job/33817861940

Packages published in this flow:

@drwpow
Copy link
Contributor

drwpow commented Dec 4, 2024

Thanks for raising! This was a hiccup in our automated publish pipeline. Will have refreshes out shortly fixing the issue.

@drwpow drwpow self-assigned this Dec 4, 2024
@drwpow
Copy link
Contributor

drwpow commented Dec 4, 2024

@drwpow could this be because of the turborepo upgrade?

Also just for internal reference, this did happen in the Turborepo PR, but was 100% unrelated to Turborepo. This was the offending line:

https://github.com/openapi-ts/openapi-typescript/pull/2027/files#diff-87db21a973eed4fef5f32b267aa60fcee5cbdf03c67fafdc2a9b553bb0b15f34L24

-    - run: pnpm run build

There’s a weird quirk about the Changesets release where the version script doesn’t run every time. During the actual release, you do need to run pnpm run build independently of the version script (which also has a build inside). I had forgotten this is needed because of changesets, and I falsely assumed this “extra” build would just happen magically with Turborepo. This behavior is undocumented. So I wrote a comment in ci/.release.yml reminding us should this ever happen again.

@drwpow
Copy link
Contributor

drwpow commented Dec 4, 2024

openapi-fetch and openapi-react-query got refreshes (you’ll have to update to the latest patch; for obvious reasons npm doesn’t let you re-publish a version), and confirmed the dist/ folder was published correctly. Sorry for the inconvenience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working openapi-fetch Relevant to the openapi-fetch library
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants