Skip to content

Property mapper function #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 2, 2020
Merged

Conversation

atlefren
Copy link
Contributor

As discussed in #77 .

Had to change the logic in properties handling a bit, and introduced a new interface Properties. In addition, the Swagger2Definition interface is now exported from the top-level, as it is used in the mapper.

New tests added for the new functionality, all existing tests still passes. Readme is also updated.

Comments and suggestions welcome.

@codecov
Copy link

codecov bot commented Jan 15, 2020

Codecov Report

Merging #118 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #118   +/-   ##
=======================================
  Coverage   98.11%   98.11%           
=======================================
  Files           2        2           
  Lines         106      106           
  Branches       40       41    +1     
=======================================
  Hits          104      104           
  Misses          2        2
Impacted Files Coverage Δ
src/index.ts 100% <ø> (ø) ⬆️
src/swagger-2.ts 98% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c24b3ef...794c16b. Read the comment docs.

Copy link
Contributor

@drwpow drwpow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stellar work, @atlefren! I literally have no comments/questions. The code, tests, README additions, everything—really high-quality and make perfect sense to me. Going to merge this now and cut a new version!

@drwpow drwpow merged commit 439096d into openapi-ts:master Feb 2, 2020
@atlefren
Copy link
Contributor Author

atlefren commented Feb 3, 2020

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants