feat(openapi-fetch): baseUrl per request #1817
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 21a5e4c The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
kerwanp
requested changes
Aug 9, 2024
Co-authored-by: Martin Paucot <[email protected]>
kerwanp
approved these changes
Aug 18, 2024
This was referenced Aug 18, 2024
Merged
drwpow
reviewed
Aug 29, 2024
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| "openapi-fetch": minor | |||
There was a problem hiding this comment.
Just a note for next time: we’re using minor patches only for breaking changes while we’re on 0.x on openapi-fetch. patch includes feature additions and bugfixes before 1.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
ref: #1633
Now
baseUrlcan be set per request and it should take precedence overbaseUrlclient option:How to Review
The tests should pass.
Checklist
docs/updated (if necessary)pnpm run update:examplesrun (only applicable for openapi-typescript)