Skip to content

Conversation

drwpow
Copy link
Contributor

@drwpow drwpow commented Sep 3, 2024

Changes

Part of #1818. #1895 removed MSW from benchmarks, but didn’t get the benchmarks working.

But it seems removing MSW has greatly improved consistency. I’m seeing really consistent runs for openapi-fetch, openapi-fetch (path-based), and openapi-typescript-fetch.

There’s still a missing mock needed for libraries that don’t use globalThis.fetch directly (axios, superagent, openapi-typescript-codegen), but that can be handled in a followup.

How to Review

  • pnpm run bench:js works in openapi-fetch

Checklist

N/A

@drwpow drwpow requested a review from a team as a code owner September 3, 2024 17:08
Copy link

changeset-bot bot commented Sep 3, 2024

⚠️ No Changeset found

Latest commit: 4deb729

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 3, 2024

size-limit report 📦

Path Size
packages/openapi-fetch/dist/index.min.js 5.85 KB (0%)

@drwpow drwpow merged commit 5a227eb into main Sep 3, 2024
9 of 10 checks passed
@drwpow drwpow deleted the benchmark branch September 3, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant