Skip to content

Conversation

htunnicliff
Copy link
Member

@htunnicliff htunnicliff commented Sep 27, 2024

Changes

Adds swr-openapi package.

How to Review

@drwpow I'd love your thoughts on:

  • Should I switch from ESLint to Biome? Switched ✅
  • Does the NPM_TOKEN secret for this repo need modification? (I've added you as a maintainer for the package in NPM)
  • Should I create a CHANGELOG.md for the package? (I've used Github releases up to this point, so I don't have an existing changelog file).
  • For docs: Would you like Vitepress updated in this PR, or would a later follow-up PR be better? I went ahead and added some docs! ✅
  • Any other updates you'd like to see!

Thank you!

@htunnicliff htunnicliff requested a review from a team as a code owner September 27, 2024 18:07
Copy link

changeset-bot bot commented Sep 27, 2024

🦋 Changeset detected

Latest commit: ef68e0e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
swr-openapi Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@drwpow
Copy link
Contributor

drwpow commented Oct 2, 2024

Thanks so much for all your work, and for wanting to merge these projects! Sorry I’ve had a really busy week, but will give it a review soon.

@prescottprue
Copy link

Just wanted to share that we had our team using swr-openapi for about a year and it worked great. Really excited to see the proposal to have this be an openapi-typescript shared package 👏

@kerwanp
Copy link
Contributor

kerwanp commented Oct 14, 2024

Hey! Incredible work with swr-openapi. Happy to see it join the openapi-typescript ecosystem.

I think it would be interesting to publish this package under openapi-swr (or both), or even start releasing under an org to keep consistency across packages. As it is not heavily used yet it would not have a huge impact.

What do you think @drwpow?

Copy link
Contributor

@drwpow drwpow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great first pass! I don’t have any feedback on this cut; just happy to include it in the project 🙂

@htunnicliff
Copy link
Member Author

@drwpow I made some small adjustments to fix a CI bug, as well as pointing the README to the new docs page.

Feel free to merge when ready!

@htunnicliff
Copy link
Member Author

Hey Drew! Checking in here – are you ready to merge this? I don't yet have permission to merge.

@drwpow
Copy link
Contributor

drwpow commented Nov 5, 2024

Thanks for the ping! I’ve had limited time to devote to maintenance this month (which is why more maintainer support is needed 🙂). Will merge this & add you with write permissions!

@drwpow drwpow merged commit 639ec45 into openapi-ts:main Nov 5, 2024
8 checks passed
@openapi-ts-bot openapi-ts-bot mentioned this pull request Nov 5, 2024
DjordyKoert pushed a commit to DjordyKoert/openapi-typescript that referenced this pull request Nov 28, 2024
* Add unmodified source

* Update package.json

* Add minor changeset

* Fix funding

* Fix path for windows

* Replace ESLint and Prettier with Biome

* Add documentation

* Enable deep on page outlines

* Update lockfile

* Replace README docs with link to Vitepress docs

* Update contributors.json

* Fix del cli
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants