-
-
Notifications
You must be signed in to change notification settings - Fork 576
Add swr-openapi package #1932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add swr-openapi package #1932
Conversation
🦋 Changeset detectedLatest commit: ef68e0e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
43e7c36
to
4b0a584
Compare
Thanks so much for all your work, and for wanting to merge these projects! Sorry I’ve had a really busy week, but will give it a review soon. |
Just wanted to share that we had our team using swr-openapi for about a year and it worked great. Really excited to see the proposal to have this be an openapi-typescript shared package 👏 |
Hey! Incredible work with swr-openapi. Happy to see it join the openapi-typescript ecosystem. I think it would be interesting to publish this package under What do you think @drwpow? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great first pass! I don’t have any feedback on this cut; just happy to include it in the project 🙂
5efe96e
to
5e3595d
Compare
@drwpow I made some small adjustments to fix a CI bug, as well as pointing the README to the new docs page. Feel free to merge when ready! |
Hey Drew! Checking in here – are you ready to merge this? I don't yet have permission to merge. |
Thanks for the ping! I’ve had limited time to devote to maintenance this month (which is why more maintainer support is needed 🙂). Will merge this & add you with write permissions! |
* Add unmodified source * Update package.json * Add minor changeset * Fix funding * Fix path for windows * Replace ESLint and Prettier with Biome * Add documentation * Enable deep on page outlines * Update lockfile * Replace README docs with link to Vitepress docs * Update contributors.json * Fix del cli
Changes
Adds swr-openapi package.
How to Review
@drwpow I'd love your thoughts on:
Should I switch from ESLint to Biome?Switched ✅NPM_TOKEN
secret for this repo need modification? (I've added you as a maintainer for the package in NPM)For docs: Would you like Vitepress updated in this PR, or would a later follow-up PR be better?I went ahead and added some docs! ✅Thank you!