fix(openapi-fetch): Prevent orphan ampersands in query from empty arrays #1936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4f9d2f3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
drwpow
approved these changes
Oct 25, 2024
Merged
Dafnik
added a commit
to Dafnik/dfts-common
that referenced
this pull request
Dec 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes a case where multiple empty arrays are passed as query params will create multiple orphaned ampersands in the resultant request URL
Closes #1935
How to Review
I decided to effectively ignore empty arrays in the querySerializer, the issue was they were returning
""fromseralizeArrayParamwhich was then caught up in the.join("&"). However, we could just as easily.filterout the empty strings and catch for the general case.Checklist
docs/updated (if necessary)pnpm run update:examplesrun (only applicable for openapi-typescript)