Fix boolean props #2199
Merged
Fix boolean props #2199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for openapi-ts failed.
|
🦋 Changeset detectedLatest commit: 5617b57 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
drwpow
approved these changes
Mar 19, 2025
Merged
|
Thank you @drwpow! Happy to contribute to a fantastic set of tools. |
ut0xygen
pushed a commit
to ut0xygen/openapi-typescript
that referenced
this pull request
Aug 5, 2025
* Add failing test case for boolean object props * Fix boolean object props * Add changeset --------- Co-authored-by: Stefan Terdell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds support for boolean property schemas, ie:
{ "type": "object", "properties": { "truthy": true, "falsy": false } }The PR changes the flow in the loop handling object properties to reach "edge-case" handling that was already present for boolean schemas. This was previously not reached due to an early error that was thrown if the property schema was not an object. Properties that were previously accessed directly from the schema object are now extracted conditionally before hand.
Closes #2198.
How to Review
See the added test case for details.
Checklist
docs/updated (if necessary)pnpm run update:examplesrun (only applicable for openapi-typescript)