additionalProperties interpolation, primitive enums #266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skh-
changed the title
|
had another problem where: would produce Added fix to this PR. |
skh-
changed the title
|
@all-contributors please add @skh- for code, test |
|
I've put up a pull request to add @skh! 🎉 |
Closed
|
@drwpow if you would like maintenance help with the repo feel free to tap me 😄 . |
|
@skh- awesome! Yes I would… as soon as I’m able to get access to the repo again (still locked out of npm deployments and adding contributors at the moment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if
additionalPropertiesis not of a primitive type, the generated file will contain things likereforarrayinstead of interpolating that ref or array. this PR should fix that and #265.not aware of any side effects, let me know if you can think of any.