Skip to content

Add support for http ports #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

vansosnin
Copy link

Add support for ports. I have a case: run swagger on localhost:5000. And now I have an error:

❌ "Error: getaddrinfo ENOTFOUND localhost:5000"
Error: � version missing from schema; specify whether this is OpenAPI v3 or v2 https://swagger.io/specification
    at swaggerVersion (C:\Users\isosnin\AppData\Roaming\npm-cache\_npx\38628\node_modules\@manifoldco\swagger-to-ts\dist-node\index.js:126:9)
    at swaggerToTS (C:\Users\isosnin\AppData\Roaming\npm-cache\_npx\38628\node_modules\@manifoldco\swagger-to-ts\dist-node\index.js:352:19)
    at C:\Users\isosnin\AppData\Roaming\npm-cache\_npx\38628\node_modules\@manifoldco\swagger-to-ts\bin\cli.js:48:18
    at processTicksAndRejections (internal/process/task_queues.js:97:5)

This PR fixes issue.

@vansosnin
Copy link
Author

@drwpow ping

@selbekk
Copy link
Contributor

selbekk commented Jul 23, 2020

Would love to see this merged and released.

@nathanstanford2
Copy link

This looks like a good fix to me. Definitely something I need as well. I tried to review it for you, but I guess since I'm not on the team I can't actually review it haha! Would love to see this release go out.

@drwpow
Copy link
Contributor

drwpow commented Jul 30, 2020

Hey, sorry—in the last couple months I’ve left Manifold and no longer have admin access to this repo or the npm deployment. I was the primary author/maintainer of this project. I had been talking with Manifold about the future of this project, but we never reached any conclusions. Let me ping them again.

Worst case scenario, this gets forked somewhere else and development continues as normal. Thanks for your patience!

@drwpow
Copy link
Contributor

drwpow commented Aug 8, 2020

Thanks for the fix, but I merged in order and this was already handled in #252 (and #289). Will go out in the next release!

@drwpow drwpow closed this Aug 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants