Add paths support #328
Merged
Add paths support #328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drwpow
commented
Oct 8, 2020
| > = {}; | ||
| responses.parameters.forEach((p) => { | ||
| if (!allParameters[p.in]) allParameters[p.in] = {}; | ||
| // TODO: handle $ref parameters |
There was a problem hiding this comment.
parameters can be a $ref rather than an object. The first cut doesn’t handle that (yet)
drwpow
commented
Oct 8, 2020
|
|
||
| finalOutput += "export interface components {\n"; | ||
|
|
||
| // TODO: handle components.parameters |
There was a problem hiding this comment.
We also don’t yet handle components.parameters, which would be needed for $ref parameters (above)
Codecov Report
@@ Coverage Diff @@
## master #328 +/- ##
==========================================
+ Coverage 86.40% 88.93% +2.53%
==========================================
Files 5 5
Lines 250 226 -24
Branches 88 77 -11
==========================================
- Hits 216 201 -15
+ Misses 22 18 -4
+ Partials 12 7 -5
Continue to review full report at Codecov.
|
gr2m
added a commit
to octokit/openapi-types.ts
that referenced
this pull request
Oct 14, 2020
using currently unreleased version of `swagger-to-ts`, see openapi-ts/openapi-typescript#328
|
fyi I'm currently exploring generating types from GitHub's OpenAPI spec and will send pull requests to address the bugs I've found. See octokit/openapi-types.ts#1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Satisfies #236. Though this doesn’t have 100% of all paths features, it’s at least a start 🙂
cc @gr2m (wanted to tag you to let you know this is done, and will be ready for testing in the next release!)