Fix wrong generated type when processing enums containing "null" #492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #492 +/- ##
==========================================
+ Coverage 78.52% 78.80% +0.28%
==========================================
Files 9 9
Lines 298 302 +4
Branches 92 95 +3
==========================================
+ Hits 234 238 +4
Misses 64 64
Continue to review full report at Codecov.
|
FedeBev
changed the title
drwpow
reviewed
Mar 2, 2021
| if (typeof item === "string") items.push(`'${item.replace(/'/g, "\\'")}'`); | ||
| else if (typeof item === "number" || typeof item === "boolean") items.push(item); | ||
| else if (item === null && !node.nullable) items.push("null"); | ||
| }); |
There was a problem hiding this comment.
Very nice! This is much better handling than we were doing.
drwpow
reviewed
Mar 2, 2021
| type: "object", | ||
| }) | ||
| ).toBe(`{ | ||
| "string"?: (('Totoro') | (2) | (false)) | null; |
drwpow
reviewed
Mar 2, 2021
| properties: | ||
| myField: | ||
| type: string | ||
| enum: ["foo", 2, false, null] |
There was a problem hiding this comment.
Nice! Thanks for adding a snapshot test, too 💯
|
This looks great! Thank you 🙏🏻 |
|
@all-contributors please add @FedeBev for bug, code, test |
|
I've put up a pull request to add @FedeBev! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
this is a WIP PR cointaining a failing test related to issue #482this PR contains a fix for the issue #482.
Please note: I tried to keep the enum generation logic as is, but in my opinion an enum declared as string should not be allowed to contain number or boolean.