Skip to content

ci: use node.js version from matrix #539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 24, 2021
Merged

Conversation

dnalborczyk
Copy link
Contributor

@dnalborczyk dnalborczyk commented Mar 24, 2021

fixes: #530 (comment)

also included node.js v15

v10 can probably dropped end-of-April: https://nodejs.org/en/about/releases/ and replaced with v16 (while v15 to be removed)

@codecov
Copy link

codecov bot commented Mar 24, 2021

Codecov Report

Merging #539 (0b4d0f7) into main (ca0018d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #539   +/-   ##
=======================================
  Coverage   84.87%   84.87%           
=======================================
  Files           9        9           
  Lines         324      324           
  Branches      105      105           
=======================================
  Hits          275      275           
  Misses         46       46           
  Partials        3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58a263a...0b4d0f7. Read the comment docs.

Copy link
Contributor

@drwpow drwpow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

D‘oh! Thanks for fixing this. Also thanks for adding Node 15. I’ve been using it locally, but always good to have it in CI too.

@drwpow drwpow merged commit d72b8c7 into openapi-ts:main Mar 24, 2021
@dnalborczyk dnalborczyk deleted the fix-ci branch March 24, 2021 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants