Skip to content

feat(doc): prints out jsdoc #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2019
Merged

feat(doc): prints out jsdoc #67

merged 1 commit into from
Oct 1, 2019

Conversation

lbenie
Copy link
Contributor

@lbenie lbenie commented Sep 30, 2019

Instead of having regular comments. Let's use jsdoc comments.

closes #57

@drwpow
Copy link
Contributor

drwpow commented Oct 1, 2019

@lbenie Awesome! I’m cool with this change.

Do me a favor and run npm run generate to re-generate the example, then commit that file. That’s why thy Travis tests are failing. But once that’s good, happy to merge & ship!

@lbenie
Copy link
Contributor Author

lbenie commented Oct 1, 2019

@DangoDev done !

@codecov
Copy link

codecov bot commented Oct 1, 2019

Codecov Report

Merging #67 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #67   +/-   ##
=======================================
  Coverage   97.97%   97.97%           
=======================================
  Files           2        2           
  Lines          99       99           
  Branches       38       38           
=======================================
  Hits           97       97           
  Misses          2        2
Impacted Files Coverage Δ
src/swagger-2.ts 97.84% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 733e317...295da46. Read the comment docs.

@drwpow drwpow merged commit e874b6c into openapi-ts:master Oct 1, 2019
@drwpow
Copy link
Contributor

drwpow commented Oct 1, 2019

Published 1.4.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Descriptions as JSDoc comments
2 participants