Skip to content

Convert names containing spaces to use underscores #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 12, 2019

Conversation

svnv
Copy link
Contributor

@svnv svnv commented Oct 14, 2019

Should hopefully close #66

@codecov
Copy link

codecov bot commented Oct 14, 2019

Codecov Report

Merging #75 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #75      +/-   ##
==========================================
+ Coverage   98.05%   98.11%   +0.05%     
==========================================
  Files           2        2              
  Lines         103      106       +3     
  Branches       40       40              
==========================================
+ Hits          101      104       +3     
  Misses          2        2
Impacted Files Coverage Δ
src/swagger-2.ts 98% <100%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcc2cb5...46dc8c0. Read the comment docs.

@svnv svnv force-pushed the handle-names-with-spaces branch from 64bae78 to adb3e1b Compare October 14, 2019 20:41
@ali-alidoust
Copy link

I still get the error. This time where the space containing model name is used as a type.

SyntaxError: ';' expected. (1776:17)
  1774 | uri?: string;
  1775 | parameters?: BatchServiceParameterSrv[];
> 1776 | result?: Result model;
       |                 ^
  1777 | }
  1778 | export interface BatchServiceParameterSrv {
  1779 | name?: string;

@svnv
Copy link
Contributor Author

svnv commented Oct 31, 2019

Right, added a commit dealing with models being used.

Copy link
Contributor

@drwpow drwpow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Sorry for the delay on this.

@drwpow drwpow merged commit e29254b into openapi-ts:master Dec 12, 2019
@drwpow
Copy link
Contributor

drwpow commented Dec 12, 2019

Hey @svnv so sorry for the delay on reviewing. I think my notifications for this repo are a bit messed up—I didn’t see the email go through. Was reviewing things today and noticed this great PR. Bumping the version now; hopefully this wasn’t too inconvenient.

@drwpow
Copy link
Contributor

drwpow commented Dec 12, 2019

[email protected] published to npm 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breaks when there are spaces in models names
3 participants