This repository was archived by the owner on Feb 18, 2025. It is now read-only.
Better semi-sync analysis #1171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- rpl_semi_sync_master_timeout, as semi_sync_master_timeout - rpl_semi_sync_master_wait_for_slave_count, as semi_sync_master_wait_for_slave_count
… semi sync plugins are loaded
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
orchestratorto probe and collect more granular semi-sync variables/status, including:rpl_semi_sync_master_enabledrpl_semi_sync_master_timeoutrpl_semi_sync_master_wait_for_slave_countrpl_semi_sync_slave_enabledRpl_semi_sync_master_statusRpl_semi_sync_slave_statuspreviously, we only collected:
Rpl_semi_sync_master_statusRpl_semi_sync_slave_statusand treated them as
*_enabled. We now differentiate between the configuration expecting semi-sync to be enabled, and the actual operational status.Added two structure analysis types:
NoValidSemiSyncReplicasStructureWarning, when master expects semi-sync but no valid semi-sync replicas foundNotEnoughValidSemiSyncReplicasStructureWarning, when master expects semi sync but less than that number of valid semi-sync replicas found.Added integration tests.