Skip to content
This repository was archived by the owner on Sep 11, 2023. It is now read-only.

Document the contents & shapes of the NetCDF files that nowcasting_dataset outputs? #227

Open
Tracked by #393
JackKelly opened this issue Oct 13, 2021 · 2 comments
Labels
discussion documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers

Comments

@JackKelly
Copy link
Member

JackKelly commented Oct 13, 2021

The Pydantic models in the data_sources/<modality>/<modality>_model.py files (where <modality> is one of {datetime, metadata, gsp, nwp, pv, satellite, sun, topographic}) describe the contents of the batches (and, hence, the contents of the NetCDF files). (For example, see satellite_model.py).

But it might be nice to aggregate all that documentation together into a single human-readable page somewhere? So it's really quick and easy for users to get an overview (and to see the detail) of precisely what nowcasting_dataset outputs to disk?

I guess the ideal situation would be to automatically extract the description fields from the pydantic models? I wonder if sphinx can do that?!

Related to #222

@JackKelly JackKelly added discussion documentation Improvements or additions to documentation enhancement New feature or request labels Oct 13, 2021
@JackKelly
Copy link
Member Author

JackKelly commented Oct 13, 2021

I guess the ideal situation would be to automatically extract the description fields from the pydantic models? I wonder if sphinx can do that?!

Yup, it can! https://sphinx-pydantic.readthedocs.io/en/latest/

@peterdudfield
Copy link
Contributor

The 'data_sources' are now basically 'xr.Datasets', with a few pydantic features.

Perhaps a good start is just to write a descirption in eahc of the data_sources/<modality>/<modality>_model.py files

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
discussion documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers
Projects
No open projects
Status: Todo
Development

No branches or pull requests

2 participants