This repository was archived by the owner on Sep 11, 2023. It is now read-only.
Issue/138 validate prepared ml data #151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # nowcasting_dataset/config/model.py # nowcasting_dataset/consts.py # nowcasting_dataset/dataset/datasets.py
jacobbieker
approved these changes
Sep 24, 2021
| "WV_073", | ||
| ) | ||
|
|
||
| DEFAULT_REQUIRED_KEYS = [ |
4 tasks
|
@JackKelly gona merge this, so that this PR can use some of this stuff. Please do add comments |
JackKelly
reviewed
Sep 30, 2021
| assert data[OBJECT_AT_CENTER] == "gsp" | ||
|
|
||
| if not batch: | ||
| # add an extract dimension so that its similar to batch data |
There was a problem hiding this comment.
Two tiny typos (sorry for being such a pedant... and sorry if I've misunderstood!)
- extract -> extra
- its -> it's
There was a problem hiding this comment.
you are definitely right! my bad
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Main:
Extras:
Fixes issue #138
How Has This Been Tested?
Unittests + extra unittest
ran the validation script for a few batches - but need to run this on remote server/gcp
Checklist: