This repository was archived by the owner on Sep 11, 2023. It is now read-only.
Issue/153 use fsspec #214
Merged
Issue/153 use fsspec #214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterdudfield
commented
Oct 11, 2021
scripts/copy_from_gcp_to_aws.py
Outdated
| @@ -41,7 +39,9 @@ def one_file(filename): | |||
|
|
|||
| if file_index > 18000: | |||
| print(filename) | |||
| gcp_to_aws(gcp_filename=filename, aws_filename=aws_filename, aws_bucket=AWS_BUCKET, gcs=gcs) | |||
|
|
|||
| download_to_local(remote_filename=filename, local_filename="temp.nc") | |||
There was a problem hiding this comment.
should use tempfile here, in can this is run across multi-processes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Remove aws and gcp specific functions
Very little new code has been writen, just remove the aws and gcs files, and changes to use fsspec
Fixes #153
How Has This Been Tested?
unittests
Checklist: