This repository was archived by the owner on Sep 11, 2023. It is now read-only.
speed up loading, and speed up tests #245
Merged
+48
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackKelly
reviewed
Oct 20, 2021
| # Submit tasks to the executor. | ||
| for data_source in self.data_sources: | ||
| if data_source is not None: | ||
| _ = executor.submit( |
There was a problem hiding this comment.
I could be wrong but I think it's a good idea to keep these Future objects in a list, and then loop through the list of Future objects and wait on future.result() (just like you do in load_netcdf(). Mostly because I think that Exceptions from save_netcdf might get silently swallowed until you call future.result()? Or maybe Exceptions only get silently swallowed if using ProcessPoolExecutor, I'm not sure?!
There was a problem hiding this comment.
Yea that I'm not sure, have to look into that
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Save and Load netcdf in parallel
Fixes #244
How Has This Been Tested?
wiht unittest, not on full netcdf files
Checklist: