Skip to content
This repository was archived by the owner on Sep 11, 2023. It is now read-only.

Remove cloud from YAML config. #153 #281

Merged
merged 2 commits into from
Oct 26, 2021
Merged

Conversation

JackKelly
Copy link
Member

@JackKelly JackKelly commented Oct 26, 2021

Pull Request

Description

Remove the cloud field from the YAML config.

Also fix a few tiny tipos 🙂

We no longer need the cloud config because nowcasting_dataset determines the compute environment from the protocol prefix on each filename (e.g. gs://bucket/path/zarr for Google Storage).

Fixes #153

How Has This Been Tested?

Tests pass

  • No
  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@JackKelly JackKelly requested a review from jacobbieker October 26, 2021 08:44
@JackKelly JackKelly self-assigned this Oct 26, 2021
@JackKelly JackKelly requested a review from flowirtz October 26, 2021 08:45
@JackKelly
Copy link
Member Author

Thanks for the super-speed reviews, @flowirtz and @jacobbieker !

@JackKelly JackKelly merged commit 062e4de into main Oct 26, 2021
@JackKelly JackKelly deleted the jack/remove-cloud-from-config branch October 26, 2021 08:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Use fsspec and/or pathy to provide a unified interface to GCP, AWS, and local filesystems
3 participants