Skip to content
This repository was archived by the owner on Sep 11, 2023. It is now read-only.

Speed up gsp locations #375

Merged
merged 7 commits into from
Nov 16, 2021
Merged

Speed up gsp locations #375

merged 7 commits into from
Nov 16, 2021

Conversation

peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented Nov 12, 2021

Pull Request

Description

Speed up gsp locations by

  • checking to see if no nans,
  • if no nans get gsp locations in one go

Fixes #304

How Has This Been Tested?

  • unittest tests,

  • tested for speed up, for 10 gsps, ~0.13 seconds to --> ~0.01 seconds ===== X10 speed up

  • No

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@peterdudfield peterdudfield marked this pull request as ready for review November 12, 2021 17:20
@JackKelly JackKelly added the enhancement New feature or request label Nov 16, 2021
Copy link
Member

@JackKelly JackKelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this! A really elegant solution! And a 10x speedup is fantastic!

Two tiny comments...

@JackKelly JackKelly linked an issue Nov 16, 2021 that may be closed by this pull request
@peterdudfield peterdudfield merged commit c97b0fe into main Nov 16, 2021
@peterdudfield peterdudfield deleted the issue/304-gsp-speed-up branch November 16, 2021 13:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
No open projects
Status: Done
2 participants