-
Notifications
You must be signed in to change notification settings - Fork 160
Add completion menu for file paths #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add completion menu for file paths #145
Conversation
@kujtimiihoxha Not sure who to tag, hope this is fair to ask your opinion on this |
251f602
to
56c0c7f
Compare
@Adictya first of all this is such an awesome PR 🤩 , especially for the first time writing go 🙌
I would say if you can find a way to simplify it and add a common component I am all for it.
I think a combination of this would be the best, check if the user has fzf installed and use it or if not fallback to a library. This is looking really really great... |
Haha, thanks man! Ill get on it. |
} | ||
|
||
commonIgnoredDirs := map[string]bool{ | ||
".opencode": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added opencode to common ignored dirs
@kujtimiihoxha Ready for review! Let me know if this looks good, I can go ahead with the tests after your review |
Addresses #66

Demo:
I have added the autocomplete functionality. But had a couple of questions I would like the maintainers opinions on:
I found myself copying a lot of code from the commands dialog or the new themes dialog for the list, does it make sense to have a simple list component for all of these usecases? I can work on it as part of this pr.
I really would love fuzzy search to be in as well, Does it make more sense to have a package that does it or rely on system having "fzf" and passing the query to that instead.
Will proceed with finalizing the code once I can get more clarity, just a couple of hours work left. It was a great experience working first time in Go.