libct/cg: don't return OOMKillCount error when rootless #2910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For fs, commit fc620fd made rootless field private, and for fs2, it was always private, and yet comments in both mention it as m.Rootless. Fix it. Signed-off-by: Kir Kolyshkin <[email protected]>
Commit 5d0ffbf added OOM kill count checking and better container start/run/exec error reporting in case we hit OOM. It also introduced warnings like these: > level=warning msg="unable to get oom kill count" error="openat2 > /sys/fs/cgroup/user.slice/user-1000.slice/[email protected]/test_hello/memory.events: > no such file or directory" In case of rootless containers, unless cgroup is delegated or systemd is used, runc can not create a cgroup and thus it fails to get OOM kill count. This is expected, and the warning should not be shown in this case. Signed-off-by: Kir Kolyshkin <[email protected]>
mrunalp
approved these changes
Apr 15, 2021
AkihiroSuda
approved these changes
Apr 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #2812 (commit 5d0ffbf) added OOM kill count checking and better container
start/run/exec error reporting in case we hit OOM.
It also introduced warnings like these:
In case of rootless containers, unless cgroup is delegated or systemd is
used, runc can not create a cgroup and thus it fails to get OOM kill
count. This is expected, and the warning should not be shown in this
case.