Skip to content

crnnFP16 #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 8, 2022
Merged

crnnFP16 #79

merged 3 commits into from
Sep 8, 2022

Conversation

Charles-258
Copy link
Contributor

add two crnn quantized models

@Charles-258 Charles-258 reopened this Aug 3, 2022
Comment on lines 7 to 13
| Models | Accuracy(%) |
| ------ | -------------- |
| CRNN_EN | 81.66 |
| CRNN_EN_FP16 | 82.01 |
| CRNN_CH | 71.28 |
| CRNN_CH_FP16 | 78.63 |
\*: 'FP16' stands for 'model quantized into FP16'.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should carry experiment on more OCR datasets. Then, I think we can merge it. Please add info about the test dataset.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Charles-258, friendly reminder

@zihaomu zihaomu added the GSoC Google Summer of Code projected related label Sep 5, 2022
Copy link
Member

@zihaomu zihaomu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@zihaomu zihaomu merged commit 1ecf13e into opencv:master Sep 8, 2022
@fengyuentau
Copy link
Member

We need to add notes in the readme telling users how to use these fp16 models and compare the accuracy with fp32 models' as well.

@zihaomu
Copy link
Member

zihaomu commented Sep 8, 2022

@fengyuentau This info can be found in the merged PR #71.

@fengyuentau
Copy link
Member

Thank you but we still need notes in the readme about how to use these fp16 models with opencv.

@zihaomu
Copy link
Member

zihaomu commented Sep 8, 2022

In my opinion, we will have more fp16 models in the future, we need to add a unified note about how to load float16 in OpenCV. How about adding this info in https://github.com/opencv/opencv_zoo/tree/master/benchmark/README.md?
The main idea is to tell the user that loading float 16 ONNX model requires opencv with this patch PR in opencv.
The best solution for python is pip install opencv-python-rolling.

fengyuentau pushed a commit that referenced this pull request Jun 8, 2023
* add crnn CH FP16 model

* add crnn EN FP16 model
@fengyuentau fengyuentau added this to the 4.9.0 (first release) milestone Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GSoC Google Summer of Code projected related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants