Skip to content

Addition of CodeFlare SDK to datascience base image #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 of 3 tasks
dimakis opened this issue Sep 1, 2023 · 8 comments
Closed
2 of 3 tasks

Addition of CodeFlare SDK to datascience base image #197

dimakis opened this issue Sep 1, 2023 · 8 comments
Assignees
Labels
kind/feature New feature or request priority/minor An issue with the product that doesn't impact the user much or not at all (ie tech debt) rhods-1.35 rhods-2.4

Comments

@dimakis
Copy link

dimakis commented Sep 1, 2023

The codeflare project SDK lives here. It would be a great addition to the data science notebook and its subsidiaries.

Goal:

  • Install the codeflare SDK in data science and rest.

Acceptance criteria

@github-project-automation github-project-automation bot moved this to 📋 Backlog in ODH IDE Planning Sep 1, 2023
@harshad16 harshad16 added kind/feature New feature or request priority/minor An issue with the product that doesn't impact the user much or not at all (ie tech debt) labels Sep 7, 2023
@harshad16 harshad16 moved this from 📋 Backlog to 🔖Todo in ODH IDE Planning Sep 7, 2023
@harshad16
Copy link
Member

As this is targetted for the tech preview of 1.34 , targeting this for that sprint.
cc: @dimakis @anishasthana

@anishasthana
Copy link
Member

Sounds good! Thanks @harshad16

@harshad16 harshad16 moved this from 🔖Todo to 🏗 In Progress in ODH IDE Planning Sep 12, 2023
@harshad16
Copy link
Member

@harshad16
Copy link
Member

Due this, #196 (comment)
the injection is on hold.
DW team is working on removing the pytorch-lighting requirement.
project-codeflare/codeflare-sdk#360

with the new release of codeflare , we can work on reviewing.

@harshad16
Copy link
Member

@harshad16
Copy link
Member

QA:
This can be tested by setting up Distributed workload and running the demo:

  1. Setup docs: here
  2. Demo available: here

@harshad16
Copy link
Member

As the codeflare-sdk is now available in data-sceince, pytorch, tensorflow and trustyai notebooks.
Thanks everyone for working on this.
Closing this issue.

@jstourac
Copy link
Member

Just for the reference - the codeflare-sdk addition was done in this PR #205 . The other linked here are relevant updates of the SDK.

harshad16 added a commit to harshad16/odh-notebooks that referenced this issue Apr 4, 2024
…ream

Revert nginx version to 1.22 since 1.24 is not available on RHEL yet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request priority/minor An issue with the product that doesn't impact the user much or not at all (ie tech debt) rhods-1.35 rhods-2.4
Projects
Status: Done
Status: No status
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants