docs: Pare down and document AppArmor file; simplify some CI elements #248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timmc-edx
force-pushed
the
timmc/update-apparmor
branch
from
537900e to
10cdbb3
Compare
- Remove all unnecessary AppArmor rules, document all directives. - Rename AppArmor profile to `openedx_codejail_sandbox` rather than something generic. - In testing, use a sandbox dir name that doesn't depend on the Python version. There's only ever one at a time in the container. This also simplifies the AppArmor profile and allows us to just have one sudoers file. - Remove example AppArmor profile from README; just point to the one in the apparmor-profiles dir so that we can have a single copy that is maintained with best practices. - Document a more general apparmor_parser directive (`--replace` is usable on both the first and subsequent runs) that surfaces and enforces warnings. This would e.g. fail the load if the ABI mismatches. - Add some breadcrumbs on what the testing files are used for.
timmc-edx
force-pushed
the
timmc/update-apparmor
branch
from
10cdbb3 to
029ef45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--replaceis usable on both the first and subsequent runs) that surfaces and enforces warnings. This would e.g. fail the load if the ABI mismatches.