Remove gevent and use waitress in all templates #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What** - Update all templates to use waitress instead of gevent. This avoids the need to install things like gcc, make, or libffi-dev into the alpine images. The user can still install these via the ADDITIONAL_PACKAGES build arg, if they are needed. Signed-off-by: Lucas Roesler <[email protected]>
martindekov
approved these changes
May 1, 2020
There was a problem hiding this comment.
Tested with function with the python3-flask:
- Successfully built
- Successfully ran:
2020/05/01 22:06:15 Started logging stderr from function.
2020/05/01 22:06:15 Started logging stdout from function.
2020/05/01 22:06:15 OperationalMode: http
2020/05/01 22:06:15 Timeouts: read: 10s, write: 10s hard: 10s.
2020/05/01 22:06:15 Listening on port: 8080
2020/05/01 22:06:15 Writing lock-file to: /tmp/.lock
2020/05/01 22:06:15 Metrics listening on port: 8081
2020/05/01 22:09:41 POST / - 200 OK - ContentLength: 17
LGTM
martindekov
reviewed
May 1, 2020
|
Hi @LucasRoesler, I can see why we changed from gevent in the Alpine Linux variants, but was gevent needing a compilation in Debian? |
yes gevent is going to require that compile stage in any installation, unless you are installing some precompiled wheel/binary from something like conda or apt-get. The same is true for Pandas, NumPy, Pillow (i think), lxml is another common dependency that i think requires development headers (it is used in xml/html parsing, e.g. Beautifulsoup uses it) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
the need to install things like gcc, make, or libffi-dev into the
alpine images. The user can still install these via the
ADDITIONAL_PACKAGES build arg, if they are needed.
Signed-off-by: Lucas Roesler [email protected]