ofSetFullscreen - issues after entering and exit fullscreen

[dimitre]

After enter fullscreen and exit, sometimes aspect ratio is changed and window will only work correctly on fullscreen.
I've noticed this on Big Sur, apple m1, not sure if it is affect other builds too.
this only happens when my main window is created with dimensions exceeding or equaling screen size.
for example in this computer if my window width is 1439 it doesn't happen, if it is 1440 it start to happen.
vertical window size seems to influence but not sure how.
mouse coordinates are still good after the issue.

void ofApp::draw(){
    ofSetColor(255,0,70);
    ofDrawCircle(300, 300, 300);
}

bool fs = false;
void ofApp::keyPressed(int key){
    if (key == 'f') {
        fs ^=1;
        ofSetFullscreen(fs);
    }
}

Before Fullscreen

After Fullscreen

[ofTheo]

Huh. Weird. I just tried on an intel MBP and don't see the issue. Is this with 0.11.1 / 0.11.2 ?

Is your window setup for Default for Display in the Display settings of System Preferences?
Or one of the other modes?

[dimitre]

0.11.2 latest but I've noticed since before 0.11.1.
settings are "default for display" here.
Never seen on Intel also but I'm using previous macOs and XCode there.

[dimitre]

not sure if it helps, this display gives this warning when switching fullscreen and back

CVCGDisplayLink::setCurrentDisplay didn't find a valid display - falling back to 60Hz
[ error ] ofAppGLFWWindow: 65544: Cocoa: Failed to find service port for display

[ofTheo]

Hmm. I see that error coming up for other apps that use GLFW with M1 machines.

Out of curiosity does it go away if you do this in ofAppGLFWWindow::update() ?

if( targetWindowMode == OF_WINDOW){
		 int winW, winH;
		glfwGetWindowSize(windowP, &winW, &winH);
		resize_cb(windowP, currentW, currentH);
}

[dimitre]

I can confirm the issue is still happening after inserting this code in update, I've inserted at the end of update. after RPI code

[dimitre]

maybe it is related to this one glfw/glfw#1060

[petewerner]

I had a look at this today

I tried glfw-master from today and did not fix it however it did silence a bunch of chatty messages that show up on arm builds

• The issue seems to happen if width >= screen width, having height >= screen height does not seem to trigger it.
• If the window is created with mode = OF_FULLSCREEN, the issue does not seem to occur.
• I can successfully reproduce it on intel macs with 0.11.2 so its not exclusively an m1 issue.

main.cpp

    glm::vec2 dims(1920);
    ofGLWindowSettings settings;
    settings.setSize(dims.x, dims.y);
    settings.windowMode = OF_WINDOW;
    ofCreateWindow(settings);
    ofRunApp(new ofApp());

ofApp.cpp

void ofApp::draw(){
    ofDrawRectangle(0, 0, 300, 300);
}
void ofApp::keyPressed(int key){
    if (key == 'f')
        ofToggleFullscreen();
}

Happy to take suggestions about where the issue might be, the FULLSCREEN vs WINDOW thing seems to be important. I am not that familiar with that part of the code base so nothing immediately jumped out at me.

[dimitre]

it bugs me why the aspect ratio is wrong. it is like width is correct and height not.
maybe we can try to fill an issue on GLFW, they seem still far from solving this kind of issues on macOs
glfw/glfw#1857
glfw/glfw#1800
hajimehoshi/ebiten#1811

[ofTheo]

Thanks @petewerner

I think it might be worth looking at the frame buffer size before after toggling fullscreen - maybe putting a print out in these two functions?

https://github.com/openframeworks/openFrameworks/blob/master/libs/openFrameworks/app/ofAppGLFWWindow.cpp#L1581-L1611

That might help isolate where the issue is?
It also might be that one of the callbacks is not happening or getting updated so the framebuffer is getting stretched or squished?