-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Remove boost as alternative in ofConstants.h #8297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove boost as alternative in ofConstants.h #8297
Conversation
Nice, maybe we can remove experimental also #include <filesystem>
namespace of {
namespace filesystem = std::filesystem;
}
#define OF_USING_STD_FS |
Since experimental is already in there, maybe we can leave it for now to support older compilers? |
@NickHardeman might be good to add to the PR removing the VS boost references too? |
@ofTheo ah yes, just updated VS Code, then did a test building a vs code project on macOS and it compiled successfully. There are some lingering references to boost via make files, ie.
But seems a little safer to leave the exclusions in those types of files until after the v0.12.1 release. |
Sorry meant these ones:
openFrameworks/libs/openFrameworksCompiled/project/vs/openFrameworksRelease.props Line 13 in a94e7e9
openFrameworks/libs/openFrameworksCompiled/project/vs/openFrameworksRelease.props Line 13 in a94e7e9
openFrameworks/libs/openFrameworksCompiled/project/vs2019/openframeworksLib.vcxproj Line 78 in a94e7e9
Def worth doing a search: I'd do these as a separate PR but it would be nice to have it all in one squashed commit. |
boost is also referenced in a few make files; like openFrameworksCompiled / project / osx / config.osx.default.mk; since it's an exclusion, it's been left there.
Referenced for v0.12.1 here: #7588